-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Improve instruction benchmarks #9712
Conversation
5cedbf0 to
82888a1
Compare
|
/benchmark runtime pallet pallet_contracts |
|
Benchmark Runtime Pallet for branch "at-fix-benches" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
17fc103 to
05cedb6
Compare
|
/benchmark runtime pallet pallet_contracts |
|
Benchmark Runtime Pallet for branch "at-fix-benches" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
045413c to
642a7ee
Compare
|
bot merge |
|
Trying merge. |
We noticed in #9669 (review) that the instruction benchmarks acted a bit erratic. To combat this we increase the size of the instruction benchmarks in this PR. However, this increase surfaced a flaw in the stack height metering which is also fixed here (by using the freshly realeased
wasm-utils v0.18.2).The
seal_inputbenchmark is also changed to be batched. It wasn't previously, because that function wasn't be able to be called multiple times when the benchmark was written. This changed in the meantime.With his PR there are no more instructions weighted as zero and and the
Schedulelooks sensible again: