Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
46af33d
update check_polkadot_companion_build for taking care of deleted or r…
joao-paulo-parity Sep 7, 2021
9275261
scope load_our_crates into a function to ensure variables don't leak
joao-paulo-parity Sep 7, 2021
77f3524
simplify comparison
joao-paulo-parity Sep 7, 2021
0c258de
sc_utils => sc_foo (for testing's sake)
joao-paulo-parity Sep 7, 2021
82dc31d
have stricter script options
joao-paulo-parity Sep 7, 2021
a572229
no useless file substitution
joao-paulo-parity Sep 7, 2021
56e0a67
isolate check-polkadot-companion-build for faster iteration
joao-paulo-parity Sep 7, 2021
87e91fd
jq update workaround
joao-paulo-parity Sep 7, 2021
a8d3de2
fix pattern comparison
joao-paulo-parity Sep 7, 2021
40e9103
improve error message
joao-paulo-parity Sep 7, 2021
766e5bd
Revert "sc_utils => sc_foo (for testing's sake)"
joao-paulo-parity Sep 7, 2021
05e0550
more informative and readable code
joao-paulo-parity Sep 8, 2021
e06e297
offer suggestion on how to solve renamed and deleted crates' issues
joao-paulo-parity Sep 10, 2021
4220b05
use base jq from Ubuntu
joao-paulo-parity Sep 10, 2021
147590e
Merge remote-tracking branch 'origin' into jp/companion-deleted-renamed
joao-paulo-parity Sep 10, 2021
7b450db
merge master
joao-paulo-parity Sep 10, 2021
9cb4b8a
remove dependency
joao-paulo-parity Sep 10, 2021
7aca1eb
make error handling more robust
joao-paulo-parity Sep 10, 2021
b9e919b
newlines
joao-paulo-parity Sep 10, 2021
583a134
Merge branch 'master' of github.com:paritytech/substrate into jp/comp…
joao-paulo-parity Sep 24, 2021
79f0eb3
Merge branch 'master' into jp/companion-deleted-renamed
joao-paulo-parity Sep 30, 2021
397aeb9
Merge branch 'master' into jp/companion-deleted-renamed
joao-paulo-parity Sep 30, 2021
c592652
Merge branch 'master' into jp/companion-deleted-renamed
joao-paulo-parity Oct 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
newlines
  • Loading branch information
joao-paulo-parity committed Sep 10, 2021
commit b9e919b4423f500f481a379da00cd7c1c13c03ae
4 changes: 3 additions & 1 deletion .maintain/gitlab/check_polkadot_companion_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ discover_our_crates() {
# workaround for early exits not being detected in command substitution
# https://unix.stackexchange.com/questions/541969/nested-command-substitution-does-not-stop-a-script-on-a-failure-even-if-e-and-s
local last_line

while IFS= read -r crate; do
last_line="$crate"
# for avoiding duplicate entries
Expand Down Expand Up @@ -140,6 +141,7 @@ match_their_crates() {
# workaround for early exits not being detected in command substitution
# https://unix.stackexchange.com/questions/541969/nested-command-substitution-does-not-stop-a-script-on-a-failure-even-if-e-and-s
local last_line

# output will be consumed in the format:
# crate
# source
Expand Down Expand Up @@ -201,7 +203,7 @@ match_their_crates() {
if [ "${crates_not_found[@]}" ]; then
echo -e "Errors during crate matching\n"
printf "Failed to detect our crate \"%s\" referenced in $target_name\n" "${crates_not_found[@]}"
echo -e "Note: this error generally happens if you have deleted or renamed a crate and did not update it in $target_name. Consider opening a companion pull request on $target_name and referencing it in this pull request's description like:\n$target_name companion: [your companion PR here]"
echo -e "\nNote: this error generally happens if you have deleted or renamed a crate and did not update it in $target_name. Consider opening a companion pull request on $target_name and referencing it in this pull request's description like:\n$target_name companion: [your companion PR here]"
exit 1
fi
}
Expand Down