-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Use the automated call decode weight for submit_unsigned benchmark
#9766
Conversation
submit_unsigned benchmark
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
kianenigma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less weight for submit_unsigned, which was expected.
NOTE: I see that the weight for elect_queued has also changed, will look into it.
…h/substrate into kiz-fix-decode-weight-election
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
3 similar comments
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
|
we're also seeing some unexpected weight changes here: paritytech/polkadot#3865, has something in the benchmark setup changed? |
| // Storage: ElectionProviderMultiPhase Snapshot (r:0 w:1) | ||
| fn create_snapshot_internal() -> Weight { | ||
| (8_835_233_000 as Weight) | ||
| (15_488_208_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this increase accounted for?
| // Storage: ElectionProviderMultiPhase CurrentPhase (r:0 w:1) | ||
| fn elect_queued(a: u32, d: u32, ) -> Weight { | ||
| (82_395_000 as Weight) | ||
| (21_035_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there such a big decrease here?
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs ResultsERROR: Unable to push ./frame/election-provider-multi-phase/src/weights.rs |
…h/substrate into kiz-fix-decode-weight-election
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
|
/benchmark runtime pallet pallet_election_provider_multi_phase |
|
Benchmark Runtime Pallet for branch "kiz-fix-decode-weight-election" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results |
… kiz-fix-decode-weight-election
|
Okay, the last commit seemed somewhat stable, will do one more benchmarks and if there are not huge discrepancies, will merge this. Frankly, this pallet will be retired in some time, nor is it designed to be in a weight-sensitive context (e.g. a parachain), so I don't want to spend too much on it. |
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
| // Storage: ElectionProviderMultiPhase CurrentPhase (r:0 w:1) | ||
| fn on_initialize_open_unsigned() -> Weight { | ||
| (43_419_000 as Weight) | ||
| (29_117_000 as Weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seriously, this function is super trivial. I am not sure why it is changing by like 20%.
| .saturating_add((127_000 as Weight).saturating_mul(t as Weight)) | ||
| .saturating_add((307_000 as Weight).saturating_mul(v as Weight)) | ||
| // Standard Error: 2_000 | ||
| .saturating_add((133_000 as Weight).saturating_mul(t as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are more reasonable, the base weight is a bit less now, the component coefficients are a bit more, I presume in most cases the end up being the same thing, more or less.
…h/substrate into kiz-fix-decode-weight-election
|
bot merge |
|
Waiting for commit status. |
polkadot companion: paritytech/polkadot#3900