Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@eskimor
Copy link
Member

@eskimor eskimor commented Sep 13, 2021

Currently the exact cause of a network error is not shown in logs, which is quite cumbersome for debugging.

@eskimor eskimor added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 13, 2021
eskimor added a commit to paritytech/polkadot that referenced this pull request Sep 13, 2021
Right now, logged messages are hardly useful.

Together with paritytech/substrate#9768, this
should help with debugging.
@bkchr bkchr requested a review from tomaka September 13, 2021 11:27
@tomaka
Copy link
Contributor

tomaka commented Sep 13, 2021

bot merge

@ghost
Copy link

ghost commented Sep 13, 2021

Error: Github API says #9768 is not mergeable

@bkchr
Copy link
Member

bkchr commented Sep 13, 2021

bot merge

@ghost
Copy link

ghost commented Sep 13, 2021

Waiting for commit status.

@tomaka
Copy link
Contributor

tomaka commented Sep 13, 2021

Why is the bot working for you and not for me?

@bkchr
Copy link
Member

bkchr commented Sep 13, 2021

Why is the bot working for you and not for me?

I think that it did not work for you was a bug. I already reported it :D

@ghost ghost merged commit 5e5474d into master Sep 13, 2021
@ghost ghost deleted the rk-more-descriptive-errors branch September 13, 2021 12:02
bkchr pushed a commit to paritytech/polkadot that referenced this pull request Sep 14, 2021
* Better error messages.

Right now, logged messages are hardly useful.

Together with paritytech/substrate#9768, this
should help with debugging.

* cargo fmt
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants