Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

jsonrpsee: add host and origin filtering #9787

Merged
niklasad1 merged 6 commits into from
Sep 15, 2021
Merged

jsonrpsee: add host and origin filtering #9787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
426cdce
add access control in the jsonrpsee servers
niklasad1 Sep 15, 2021
a57b164
use master
niklasad1 Sep 15, 2021
085d52d
fix nits
niklasad1 Sep 15, 2021
b1d11b4
rpc runtime_version safe
niklasad1 Sep 15, 2021
a4a56d6
fix nits
niklasad1 Sep 15, 2021
fd3840d
fix grumbles
niklasad1 Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix nits
  • Loading branch information
@niklasad1
niklasad1 committed Sep 15, 2021
commit 085d52de8f6be9c4394bb1a97a2cf9e73104ebed
5 changes: 4 additions & 1 deletion client/rpc-servers/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ pub fn start_ws<M: Send + Sync + 'static>(

if let Some(cors) = cors {
// Whitelist listening address.
builder = builder.set_allowed_hosts([format!("localhost:{}", addr.port()), format!("127.0.0.1:{}", addr.port())])?;
builder = builder.set_allowed_hosts([
format!("localhost:{}", addr.port()),
format!("127.0.0.1:{}", addr.port()),
])?;
builder = builder.set_allowed_origins(cors)?;
}

Expand Down
2 changes: 0 additions & 2 deletions client/service/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,6 @@ where
),
);

// NOTE(niklasad1): we spawn jsonrpsee in seperate thread now.
// this will not shutdown the server.
task_manager.keep_alive((config.base_path, rpc));

Ok(())
Expand Down