This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Silence Kademlia InboundRequestServed event #9797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
ordian
approved these changes
Sep 16, 2021
bkchr
approved these changes
Sep 16, 2021
kpp
approved these changes
Sep 16, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR no longer generates logs for the
InboundRequestServedevent, which is the new event that got added in a recent version of libp2p-kad, and reverts #9599.We now generate a
warnonly when aOutboundQueryCompletedthat isn't handled above is received, because that's the event that we're not supposed to receive.