pallet-session: Migrate the historical part to the new pallet macro #9878

koushiro · 2021-09-28T07:09:08Z

Part of #7882

Migrate historical part of pallet-session to the new pallet attribute macro.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the pallet.

polkadot, kusama, westend and rococo use Historical as pallet name (but the current module_prefix is Session), thus need to migrate the storages.

polkadot companion: paritytech/polkadot#3949

Polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK

Signed-off-by: koushiro <[email protected]>

frame/session/src/historical/mod.rs

…istorical

koushiro · 2021-09-28T07:51:54Z

/cc @thiolliere @KiChjang PTAL

…istorical

Signed-off-by: koushiro <[email protected]>

…istorical

koushiro · 2021-10-14T06:42:33Z

@thiolliere @KiChjang @shawntabrizi Could you review this PR?

…istorical

koushiro · 2021-10-27T02:47:32Z

Does anyone have time to review this PR? 😕
This PR has been opened for a long time.

frame/session/src/historical/mod.rs

gui1117

looks good to me,

The migration needs to be tested on kusama/polkadot with try-runtime

frame/session/src/migrations/mod.rs

Signed-off-by: koushiro <[email protected]>

frame/session/src/migrations/v1.rs

Signed-off-by: koushiro <[email protected]>

kianenigma · 2021-10-31T19:48:15Z

frame/staking/src/mock.rs

 		Balances: pallet_balances::{Pallet, Call, Storage, Config<T>, Event<T>},
 		Staking: pallet_staking::{Pallet, Call, Config<T>, Storage, Event<T>},
 		Session: pallet_session::{Pallet, Call, Storage, Event, Config<T>},
+		Historical: pallet_session::historical::{Pallet, Storage},


I think it now needs to have its name in PalletInfo, for the storages, so it needs to be in construct_runtime

kianenigma

LGTM!

shawntabrizi · 2021-10-31T20:02:13Z

/tip medium

substrate-tip-bot · 2021-10-31T20:02:14Z

Please fix the following problems before calling the tip bot again:

Contributor did not properly post their Polkadot or Kusama address. Make sure the pull request has: "{network} address: {address}".

…istorical

emostov · 2021-11-10T11:56:03Z

bot merge

paritytech-processbot · 2021-11-10T11:56:11Z

Error: Github API says paritytech/polkadot#3949 is not mergeable

…istorical

Signed-off-by: koushiro <[email protected]>

…istorical

gui1117 · 2021-11-17T01:34:42Z

bot merge

paritytech-processbot · 2021-11-17T01:34:49Z

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

gui1117 · 2021-11-17T01:38:22Z

bot merge

paritytech-processbot · 2021-11-17T01:38:29Z

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

gui1117 · 2021-11-17T01:40:47Z

if the bot give up on us, we will need another approval on the companion in order to merge manually the companion on polkadot

emostov · 2021-11-17T07:12:38Z

bot merge

paritytech-processbot · 2021-11-17T07:12:47Z

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

gui1117 · 2021-11-17T07:13:54Z

bot merge force

paritytech-processbot · 2021-11-17T07:14:01Z

Error: Response error (status 404 Not Found):

{"documentation_url":"https://docs.github.com/rest/reference/pulls#get-a-pull-request","message":"Not Found"}

…aritytech#9878) * Migrate session-historical to the new pallet macro Signed-off-by: koushiro <[email protected]> * pallet-session: Migrate the historical part to the new pallet macro Signed-off-by: koushiro <[email protected]> * Fix staking test runtime Signed-off-by: koushiro <[email protected]> * Update frame/session/src/historical/mod.rs * Update frame/session/src/historical/mod.rs * update migration doc Signed-off-by: koushiro <[email protected]> * use hardcoded prefix for migration v1 Signed-off-by: koushiro <[email protected]> * cargo +nightly-2021-11-08 fmt Signed-off-by: koushiro <[email protected]> Co-authored-by: Guillaume Thiolliere <[email protected]>

koushiro added 2 commits September 28, 2021 11:34

Migrate session-historical to the new pallet macro

4901c0c

Signed-off-by: koushiro <[email protected]>

pallet-session: Migrate the historical part to the new pallet macro

2d98c6f

Signed-off-by: koushiro <[email protected]>

koushiro commented Sep 28, 2021

View reviewed changes

frame/session/src/historical/mod.rs Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

fdc8c36

…istorical

koushiro mentioned this pull request Sep 28, 2021

Companion for substrate#9878 paritytech/polkadot#3949

Merged

koushiro marked this pull request as ready for review September 28, 2021 07:51

gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 28, 2021

koushiro added 2 commits September 29, 2021 15:31

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

c8d6c8f

…istorical

Fix staking test runtime

c437265

Signed-off-by: koushiro <[email protected]>

koushiro requested a review from kianenigma as a code owner September 29, 2021 08:35

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

762c958

…istorical

koushiro added 2 commits October 22, 2021 11:19

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

875ea9e

…istorical

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

a70283b

…istorical

Update frame/session/src/historical/mod.rs

6d71796

gui1117 reviewed Oct 28, 2021

View reviewed changes

frame/session/src/historical/mod.rs Outdated Show resolved Hide resolved

Update frame/session/src/historical/mod.rs

9202ea4

gui1117 approved these changes Oct 28, 2021

View reviewed changes

frame/session/src/migrations/mod.rs Outdated Show resolved Hide resolved

update migration doc

bc2655d

Signed-off-by: koushiro <[email protected]>

gui1117 reviewed Oct 28, 2021

View reviewed changes

frame/session/src/migrations/v1.rs Outdated Show resolved Hide resolved

use hardcoded prefix for migration v1

3d98af4

Signed-off-by: koushiro <[email protected]>

kianenigma reviewed Oct 31, 2021

View reviewed changes

kianenigma approved these changes Oct 31, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

d447366

…istorical

koushiro added 2 commits November 16, 2021 13:11

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

1698d5f

…istorical

cargo +nightly-2021-11-08 fmt

97b8aff

Signed-off-by: koushiro <[email protected]>

koushiro requested a review from andresilva as a code owner November 16, 2021 05:32

Merge remote-tracking branch 'upstream/master' into migrate-session-h…

4b1baeb

…istorical

emostov approved these changes Nov 17, 2021

View reviewed changes

gui1117 merged commit cc4bf91 into paritytech:master Nov 17, 2021

koushiro deleted the migrate-session-historical branch November 17, 2021 07:31

github-actions bot mentioned this pull request Dec 2, 2021

Update substrate/polkadot/cumulus from v0.9.12 to v0.9.13 moonbeam-foundation/moonbeam#1050

Closed

ferrell-code mentioned this pull request Dec 3, 2021

Runtime Migrations for polkadot-v0.9.13 AcalaNetwork/Acala#1666

Closed

2 tasks

kianenigma mentioned this pull request Jan 11, 2022

Inaccessible data stored at session pallet paritytech/polkadot#4691

Closed

aurexav added a commit to darwinia-network/darwinia-common that referenced this pull request Aug 4, 2022

Companion of paritytech/substrate#9878

f45a2b9

pallet-session: Migrate the historical part to the new pallet macro #9878

pallet-session: Migrate the historical part to the new pallet macro #9878

Uh oh!

Conversation

koushiro commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Breaking Change ⚠️

Uh oh!

Uh oh!

koushiro commented Sep 28, 2021

Uh oh!

koushiro commented Oct 14, 2021

Uh oh!

koushiro commented Oct 27, 2021

Uh oh!

Uh oh!

gui1117 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kianenigma Oct 31, 2021

Choose a reason for hiding this comment

Uh oh!

gui1117 Oct 31, 2021

Choose a reason for hiding this comment

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

shawntabrizi commented Oct 31, 2021

Uh oh!

substrate-tip-bot bot commented Oct 31, 2021

Uh oh!

emostov commented Nov 10, 2021

Uh oh!

paritytech-processbot bot commented Nov 10, 2021

Uh oh!

gui1117 commented Nov 17, 2021

Uh oh!

paritytech-processbot bot commented Nov 17, 2021

Uh oh!

gui1117 commented Nov 17, 2021

Uh oh!

paritytech-processbot bot commented Nov 17, 2021

Uh oh!

gui1117 commented Nov 17, 2021

Uh oh!

emostov commented Nov 17, 2021

Uh oh!

paritytech-processbot bot commented Nov 17, 2021

Uh oh!

gui1117 commented Nov 17, 2021

Uh oh!

paritytech-processbot bot commented Nov 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

koushiro commented Sep 28, 2021 •

edited

Loading