weight for dispatch_as

frame/support/src/traits/dispatch.rs

@@ -56,7 +56,7 @@ pub trait OriginTrait: Sized {
 	type Call;
 
 	/// The caller origin, overarching type of all pallets origins.
-	type PalletsOrigin;
+	type PalletsOrigin: Clone;
 
 	/// The AccountId used across the system.
 	type AccountId;

frame/utility/src/benchmarking.rs

@@ -64,5 +64,13 @@ benchmarks! {
 		assert_last_event::<T>(Event::BatchCompleted.into())
 	}
 
+	dispatch_as {
+		let caller = account("caller", SEED, SEED);
+		let call = Box::new(frame_system::Call::remark { remark: vec![] }.into());
+		let origin : T::Origin = RawOrigin::Signed(caller).into();
+		let pallets_origin: <T::Origin as frame_support::traits::OriginTrait>::PalletsOrigin = origin.caller().clone();
+		let pallets_origin = Into::<T::PalletsOrigin>::into(pallets_origin.clone());
+	}: _(RawOrigin::Root, Box::new(pallets_origin), call)
+
 	impl_benchmark_test_suite!(Pallet, crate::tests::new_test_ext(), crate::tests::Test);
 }

frame/utility/src/lib.rs

@@ -97,7 +97,9 @@ pub mod pallet {
 			+ IsType<<Self as frame_system::Config>::Call>;
 
 		/// The caller origin, overarching type of all pallets origins.
-		type PalletsOrigin: Parameter + Into<<Self as frame_system::Config>::Origin>;
+		type PalletsOrigin: Parameter +
+			Into<<Self as frame_system::Config>::Origin> +
+			IsType<<<Self as frame_system::Config>::Origin as frame_support::traits::OriginTrait>::PalletsOrigin>;
 
 		/// Weight information for extrinsics in this pallet.
 		type WeightInfo: WeightInfo;
@@ -337,26 +339,26 @@ pub mod pallet {
 		/// - O(1).
 		/// - Limited storage reads.
 		/// - One DB write (event).
-		/// - Weight of derivative `call` execution + 10,000.
+		/// - Weight of derivative `call` execution + T::WeightInfo::dispatch_as().
 		/// # </weight>
 		#[pallet::weight({
 			let dispatch_info = call.get_dispatch_info();
 			(
-				dispatch_info.weight
-					.saturating_add(10_000)
+				T::WeightInfo::dispatch_as()
+					.saturating_add(dispatch_info.weight)
 					// AccountData for inner call origin accountdata.
 					.saturating_add(T::DbWeight::get().reads_writes(1, 1)),
 				dispatch_info.class,
 			)
 		})]
 		pub fn dispatch_as(
 			origin: OriginFor<T>,
-			as_origin: T::PalletsOrigin,
+			as_origin: Box<T::PalletsOrigin>,
 			call: Box<<T as Config>::Call>,
 		) -> DispatchResult {
 			ensure_root(origin)?;
 
-			let res = call.dispatch_bypass_filter(as_origin.into());
+			let res = call.dispatch_bypass_filter((*as_origin).into());
 
 			Self::deposit_event(Event::DispatchedAs(res.map(|_| ()).map_err(|e| e.error)));
 			Ok(())

frame/utility/src/weights.rs

@@ -48,6 +48,7 @@ pub trait WeightInfo {
 	fn batch(c: u32, ) -> Weight;
 	fn as_derivative() -> Weight;
 	fn batch_all(c: u32, ) -> Weight;
+	fn dispatch_as() -> Weight;
 }
 
 /// Weights for pallet_utility using the Substrate node and recommended hardware.
@@ -66,6 +67,9 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 			// Standard Error: 3_000
 			.saturating_add((7_251_000 as Weight).saturating_mul(c as Weight))
 	}
+	fn dispatch_as() -> Weight {
+		(4_030_000 as Weight)
+	}
 }
 
 // For backwards compatibility and tests
@@ -83,4 +87,7 @@ impl WeightInfo for () {
 			// Standard Error: 3_000
 			.saturating_add((7_251_000 as Weight).saturating_mul(c as Weight))
 	}
+	fn dispatch_as() -> Weight {
+		(4_030_000 as Weight)
+	}
 }