Make generic #4
Make generic #4
Conversation
| .expect("account nonce is a map") | ||
| .key(&account_id); | ||
| let client = (*self).clone(); | ||
| self.fetch_or_default(account_nonce_key).map(|nonce| { |
There was a problem hiding this comment.
Could also allow user supplied nonce to allow client side incrementing, as you originally suggested.
| let mut rt = tokio::runtime::Runtime::new().unwrap(); | ||
| rt.block_on(f) | ||
| #[derive(Clone, PartialEq, Eq)] | ||
| struct Runtime; |
There was a problem hiding this comment.
What's the reason for defining this test runtime? Types look mostly the same except Balances::OnFreeBalanceZero
There was a problem hiding this comment.
Just to make sure that the only thing required for it to work is implementing srml_system::Trait and srml_balances::Trait. If we just use the Runtime, we might miss some other trait bounds.
There was a problem hiding this comment.
It's actually only srml_system::Trait which is required.
| srml_system::CheckEra<Runtime>, | ||
| srml_system::CheckNonce<Runtime>, | ||
| srml_system::CheckWeight<Runtime>, | ||
| srml_balances::TakeFees<Runtime>, |
There was a problem hiding this comment.
If we just used node_runtime::Runtime here we could at least not require the local srml_balances::Trait impl. Though I think I am missing why this is needed
| } | ||
|
|
||
| impl StorageMetadata { | ||
| pub fn map(&self) -> Option<StorageMap> { |
There was a problem hiding this comment.
Maybe rename this storage_map or something. map says to me Functor
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
But those are only minor things, overall LGTM
2 participants
Depends on paritytech/substrate#3329