Refactor #7
Merged
Refactor #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
approved these changes
Aug 12, 2019
| metadata: self.metadata.clone(), | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Why can this no longer be derived?
Contributor
Author
There was a problem hiding this comment.
It requires System: Clone, which is annoying from a usability perspective
src/metadata.rs
Outdated
| } | ||
| _ => None, | ||
| } | ||
| .ok_or(MetadataError::StorageTypeError) |
Contributor
There was a problem hiding this comment.
Simpler just to return Ok and Err in the branches above?
| .storage("FreeBalance")? | ||
| .get_map::< | ||
| <Self::Balances as System>::AccountId, | ||
| <Self::Balances as Balances>::Balance>()?) |
Contributor
There was a problem hiding this comment.
This formatting done by rustfmt? Looks odd
Contributor
Author
There was a problem hiding this comment.
that is rustfmt... it's not perfect...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on paritytech/substrate#3370