-
Notifications
You must be signed in to change notification settings - Fork 283
Metadata: Retain a subset of metadata pallets #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
This reverts commit 725a2e5. Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
|
Awesome; looks like removing those generic types had a really notable impact! (allets like Sudo and MultiSig I guess depend on |
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; happy to see this merge :)
…out use of it for better overall wins/clarity
|
Instead of trying to strip type params out of the extrinsic type (whose effect is primarily to remove the reference to the RuntimeCall type), I now strip the RuntimeCall type variants to only include those for pallets we want to keep. This keeps the size fairly uniformly small across all pallets now (below based on artifacts/polkadot.metadata):
|
This PR strips the metadata to include only some provided pallets.
Metadata size with single pallet
The
No Genericsmeans that the extrinsic types were stripped of the generic type parameters.Those generics where not needed and include nested type IDs that are unnecessarily increasing
the final metadata size. (Relies on paritytech/scale-info#176).
Closes #629.
// CC @paritytech/subxt-team