Skip to content

Update requirement for parity-util-mem #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ordian merged 4 commits into from
Jul 2, 2021
Merged

Update requirement for parity-util-mem #137

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35f3634
Update requirement for parity-util-mem
ascjones Jul 1, 2021
7d12655
Revert `parity-scale-codec` pre-release requirement
ascjones Jul 1, 2021
c513a39
Revert `parity-scale-codec` pre-release requirement
ascjones Jul 2, 2021
6a41183
Update memory-db/Cargo.toml
ascjones Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert parity-scale-codec pre-release requirement
  • Loading branch information
@ascjones
ascjones committed Jul 2, 2021
commit c513a3957e3abf8c621cf63b8a84da653274fdb4
2 changes: 1 addition & 1 deletion test-support/reference-trie/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ hash256-std-hasher = { path = "../../hash256-std-hasher", version = "0.15.2" }
keccak-hasher = { path = "../keccak-hasher", version = "0.15.3" }
trie-db = { path = "../../trie-db", default-features = false, version = "0.22.0" }
trie-root = { path = "../../trie-root", default-features = false, version = "0.16.0" }
parity-scale-codec = { version = "2.2.0-rc.2", features = ["derive"] }
parity-scale-codec = { version = "2", features = ["derive"] }
Copy link

@ordian ordian Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this cc @Xanewok

Copy link
Contributor

@Xanewok Xanewok Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this, we'll probably pursue new minor version + max-encoded-len via feature gate as outlined in paritytech/parity-common#552 (comment)

Copy link

@ordian ordian Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably require a version bump now?

Copy link

@ordian ordian Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can yank 0.23.1 and trie-bench 0.27.1


[dev-dependencies]
trie-bench = { path = "../trie-bench", version = "0.27.1" }
Expand Down