Fix iteration for prefixed storage #15
Conversation
| /// is known to be literal. | ||
| fn get_raw_or_lookup(&'db self, node: &[u8], partial_key: &[u8]) -> Result<Cow<'db, DBValue>, H::Out, C::Error> { | ||
| match (partial_key.is_empty(), C::try_decode_hash(node)) { | ||
| match (partial_key == nibbleslice::EMPTY_ENCODED, C::try_decode_hash(node)) { |
There was a problem hiding this comment.
a bit beyond the scope of the PR, but is this match assuming that only empty partial-keys could lead to nodes small enough to fit in the hash? A small partial key would easily break that if so
There was a problem hiding this comment.
Previously (before #12) there was a check for root node here. partial_key is the key up to the node. Only the root node has it empty.
There was a problem hiding this comment.
i see, maybe a comment about that?
| } | ||
|
|
||
| /// Encoded key for storage lookup | ||
| fn encoded_key(&self) -> ElasticArray36<u8> { |
There was a problem hiding this comment.
is this not also encoded somewhere else?
There was a problem hiding this comment.
This is a method of TrieDBIterator, which manages current key as a vector of nibbles. I considered switching to NibbleVec instead, that uses compact form and can be trivially converted to NibbleSlice. Unfortunately the conversion would only work for even number of nibbles, and it is not trivial to fix that.
Trie iteration was not implemented correctly in #12
Also switched tests to use prefixed storage.