Skip to content

Improve runtime check configurability #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Improve runtime check configurability #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5284d4d
improve flexibility of checking runtimes
liamaharon Nov 17, 2023
d0e09ec
improve name
liamaharon Nov 17, 2023
42025ee
Merge branch 'main' into liam-better-runtime-check-customisability
liamaharon Nov 17, 2023
18b13c0
fix up merge
liamaharon Nov 17, 2023
476a6a2
fix comment
liamaharon Nov 17, 2023
12b6408
Merge branch 'main' into liam-better-runtime-check-customisability
liamaharon Nov 20, 2023
e40ce03
write tests and tweak api
liamaharon Nov 21, 2023
fcc346e
bump version
liamaharon Nov 21, 2023
71729b4
remove bad comment
liamaharon Nov 21, 2023
4b8e40a
remove dbg
liamaharon Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove dbg
  • Loading branch information
@liamaharon
liamaharon committed Nov 21, 2023
commit 4b8e40a89eba899af254480f592e408124da652e
2 changes: 0 additions & 2 deletions core/src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,6 @@ impl State {
new_code_hash
);

dbg!(&runtime_checks);

if runtime_checks.name_matches && new_version.spec_name != old_version.spec_name {
return Err(
"Spec names must match. Use `--disable-spec-name-check` to disable this check."
Expand Down
4 changes: 0 additions & 4 deletions core/tests/on_runtime_upgrade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,8 @@ mod on_runtime_upgrade {
"{}/tests/runtimes/bridge_hub_rococo_runtime_ok.compact.compressed.wasm",
project_root
);
dbg!(&runtime_path, &snap_path);
let child = on_runtime_upgrade(snap_path.as_str(), runtime_path.as_str(), &[], &[]);
let out = child.wait_with_output().await.unwrap();
dbg!(&out);
assert!(out.status.success());
})
.await;
Expand Down Expand Up @@ -209,7 +207,6 @@ mod on_runtime_upgrade {
&[],
);
let out = child.wait_with_output().await.unwrap();
dbg!(&out);
assert!(out.status.success());
})
.await;
Expand Down Expand Up @@ -248,7 +245,6 @@ mod on_runtime_upgrade {
&["--disable-spec-version-check"],
);
let out = child.wait_with_output().await.unwrap();
dbg!(&out);
assert!(out.status.success());
})
.await;
Expand Down