Skip to content

Expose snapshot-path arg #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2024
Merged

Expose snapshot-path arg #80

merged 3 commits into from
Mar 4, 2024

Conversation

@ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 3, 2024

No description provided.

liamaharon
liamaharon approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could also write #[clap(index = 0)] for From to be extra explicit.

@ggwpez
Copy link
Member Author

ggwpez commented Mar 4, 2024

LGTM. Could also write #[clap(index = 0)] for From to be extra explicit.

You mean the pub from: LiveState? It has a clap(flatten), so cannot be positional.
And it seems that the index starts at 1 anyway (plus it will panic when one is skipped): https://docs.rs/clap/latest/clap/struct.Arg.html#method.index

@liamaharon liamaharon merged commit 13ee499 into main Mar 4, 2024
@ggwpez ggwpez deleted the oty-snapshot-path-arg branch March 4, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liamaharon liamaharon liamaharon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggwpez @liamaharon