Skip to content

Conversation

DJMarlow
Copy link
Contributor

Added 3 new methods to ParseClient to support a custom API URL, host fingerprint for SSL connection with connection client and ability to disable secure connection.

Added keywords for setServerURL, setHostFingerprint, and setClientInsecure methods.
Added methods to support a custom server URL, a host fingerprint for SSL, or option to set the connection client to insecure.
Added methods to support a custom server URL, a host fingerprint for SSL, or option to set the connection client to insecure.
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me!

@acinader acinader merged commit 8ac75b6 into parse-community:master Feb 11, 2020
@acinader
Copy link
Contributor

@DJMarlow let me know if you need any further assistance.

nit: my $.02 would have been to keep the same pull request (#18) instead of closing one and opening another to maintain the discussion in one place.

feel free to keep making improvements!!!

@DJMarlow
Copy link
Contributor Author

@DJMarlow let me know if you need any further assistance.

nit: my $.02 would have been to keep the same pull request (#18) instead of closing one and opening another to maintain the discussion in one place.

feel free to keep making improvements!!!

Thanks for the feedback @acinader! Still getting used to the github best practices, i'll reach out if I have any concerns in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants