-
-
Notifications
You must be signed in to change notification settings - Fork 873
Merge all ObjC Frameworks #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7f5c89a to
3dfc01f
Compare
montymxb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just for reviewing the README. Trusting everything else (827 files changed 😱 ). Just a typo and a question.
README.md
Outdated
| pod 'Parse/UI | ||
| ``` | ||
|
|
||
| Note that in this case, the Parse framework will contain all header, so you just have to use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
will contain all headers
| @@ -107,12 +135,9 @@ of patent rights can be found in the PATENTS file in the same directory. | |||
| As of April 5, 2017, Parse, LLC has transferred this code to the parse-community organization, and will no longer be contributing to or distributing this code. | |||
|
|
|||
| [docs]: http://docs.parseplatform.org/ios/guide/ | |||
| [blog]: http://blog.parse.com/ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blog link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it as it may not contain any relevant information anymore about this repo. This seemed to be an artifact of the old parse.com where some articles would be pushed out about new SDK features or demo usages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine then. I want to get back to a point where we consistently put up posts about what we're doing, like coalescing all the ObjC frameworks 😉 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I'll write something this week, when deprecating / archiving the other repos.
|
@montymxb I copy pasted the code from the other repos. |
|
and addressed the nits ;) |
montymxb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genehmigt
. Assuming other code is good as it is unchanged from it's prior locations.
This PR integrates the FacebookUtils and TwitterUtils repo into a single codebase.
We'll probably need to re-work further the readme.
The motivation is to keep a single codebase for those libraries, and be able to distribute them all at once, instead of managing a lot of boilerplate ci code.
It also uses circle CI for the build status, and travis for releases deployment (easier to push to github for now etc...)
What's to be reviewed? Probably just the README