Skip to content

Conversation

@flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jan 14, 2018

This PR integrates the FacebookUtils and TwitterUtils repo into a single codebase.
We'll probably need to re-work further the readme.

The motivation is to keep a single codebase for those libraries, and be able to distribute them all at once, instead of managing a lot of boilerplate ci code.

It also uses circle CI for the build status, and travis for releases deployment (easier to push to github for now etc...)

What's to be reviewed? Probably just the README

@flovilmart flovilmart closed this Jan 15, 2018
@flovilmart flovilmart reopened this Jan 15, 2018
@flovilmart flovilmart requested a review from montymxb January 15, 2018 20:42
@flovilmart flovilmart changed the title Refactor structure Merge all ObjC Frameworks Jan 15, 2018
Copy link

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just for reviewing the README. Trusting everything else (827 files changed 😱 ). Just a typo and a question.

README.md Outdated
pod 'Parse/UI
```

Note that in this case, the Parse framework will contain all header, so you just have to use:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

will contain all headers

@@ -107,12 +135,9 @@ of patent rights can be found in the PATENTS file in the same directory.
As of April 5, 2017, Parse, LLC has transferred this code to the parse-community organization, and will no longer be contributing to or distributing this code.

[docs]: http://docs.parseplatform.org/ios/guide/
[blog]: http://blog.parse.com/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blog link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it as it may not contain any relevant information anymore about this repo. This seemed to be an artifact of the old parse.com where some articles would be pushed out about new SDK features or demo usages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine then. I want to get back to a point where we consistently put up posts about what we're doing, like coalescing all the ObjC frameworks 😉 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'll write something this week, when deprecating / archiving the other repos.

@flovilmart
Copy link
Contributor Author

@montymxb I copy pasted the code from the other repos.

@flovilmart
Copy link
Contributor Author

and addressed the nits ;)

Copy link

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genehmigt :octocat: . Assuming other code is good as it is unchanged from it's prior locations.

@flovilmart flovilmart merged commit 0f5a33c into master Jan 16, 2018
@flovilmart flovilmart deleted the refactor-structure branch January 16, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants