Skip to content

Try to fix travis (take 1) #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2020
Merged

Try to fix travis (take 1) #1487

merged 2 commits into from
Mar 12, 2020

Conversation

acinader
Copy link
Contributor

  1. use my github token (i think)
  2. only release on tags

see: #1482

@acinader
Try to fix travis (take 1)
0c00cbd 
1. use my github token (i think)
2. only release on tags
@acinader acinader requested a review from noobs2ninjas March 11, 2020 00:14
@acinader
Copy link
Contributor Author

@noobs2ninjas if you want to tag team on this we can use slack? I have NO IDEA how the build works for this repo, but i do have some experience muddling through travis configs between the two of use, maybe....

@acinader acinader merged commit 1e581d8 into master Mar 12, 2020
@acinader acinader deleted the try-n-fix-travis branch March 12, 2020 01:01
@noobs2ninjas noobs2ninjas linked an issue Mar 12, 2020 that may be closed by this pull request
Travis deployment config fix. #1485
Closed
drdaz
drdaz reviewed Mar 29, 2020
View reviewed changes
Copy link
Member

@drdaz drdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need to get a new Github token for the repo now 😕. This should not be visible on the plain net.

drdaz
drdaz reviewed Mar 29, 2020
View reviewed changes
.travis.yml
- provider: releases
api_key:
secure: $GITHUB_TOKEN # Set in travis-ci.org dashboard
secure: m7YayvmctH5lyHj13EV2j898P5xfEfN/ZvFm2gL/xveTNOGaET1O4ZmGmHApxC2QwIZvtwmO3U9pmB4XVVQ7kIlTsl01h84y8gx1XQqEKoQINcaVaNCsh9EdxAqj08aiwe/1dp8W8rI/ptOrxzWJDWcxKx5tMIbBzctGeL3GDKphVvD44s43oosqQCKzP+qHiI6rRRxu+0QccdbTagwd0X/yaLZ0IbTo35hWFEyJ6NfJnmCW/lNwWj86YksLCZx0eKdxUSQlIhnm0upTyowudt9bv8vSdEYi2AtRKoana/X53593O8RAVEc+S6NgMmeQ1/ZD1eDeyYLzN/z21EHb4yiwTnMUUhDBMTn8KKTiiSVDQOfAyRwtKF+1qN2iDr9Dh3A8+dCxOxJJpIPImZimt8KMCKB9WTtnJhvIoMCDpc8l29XM/oBxjCiBFxPClb9CZ74T5b+xl+yIqy2u8RiaZ1Va5vmWjMSXDsGHoZ0rJTOBkBBhyr+47yIw2VeY2z2q5hiALV3DnE5Esxyddhw7OXNZcvKriujnxcTOJwphm4XBMI/3rSH27uz7AaNdUHfTwaKqimPR06Kdv65hKmFuA5p/GuRdSYfYASvXYYrPjqKkst1FP6sWjJtpXvZIT/06RXDbGXZ6LB3TFHpOahPy8ID746OyBKgWzOB3ZCNmFCk=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, I mean. Our keys shouldn't be here.

@drdaz
Copy link
Member

drdaz commented Mar 29, 2020

@acinader This seems like a security issue; anybody can see this page. Which means anybody has access to this GitHub token, and whatever rights it gives on our repo. Am I missing something?

@acinader
Copy link
Contributor Author

acinader commented Mar 29, 2020 •
edited
Loading

Hi @drdaz -- that is not the key. It is an encrypted hash of my key.

see: https://docs.travis-ci.com/user/encrypting-files

try to use it and you'll see ;).

@drdaz
Copy link
Member

drdaz commented Mar 29, 2020

Ahh that's awesome! TIL.

panic_mode = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@drdaz drdaz drdaz left review comments

@noobs2ninjas noobs2ninjas noobs2ninjas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travis deployment config fix.
3 participants
@acinader @drdaz @noobs2ninjas