Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 11, 2023

New Pull Request Checklist

Issue Description

Code coverage has been broken for a while with a number of factors contributing to it. actions/[email protected] introduced xcode support. I'm not sure if CODECOV_TOKEN is in the in the repository secrets

https://github.com/codecov/codecov-action/releases/tag/v3.1.0

Approach

  • Remove GCC gcov flags
  • Enable Clang Coverage (lcov)
  • Remove deprecated codecov bash uploader
  • Remove codecov.yml in favor of default

TODO

  • Update Readme Badge
  • Upload CODECOV_TOKEN

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 11, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis dplewis requested a review from mtrezza March 11, 2023 02:13
@dplewis
Copy link
Member Author

dplewis commented Mar 11, 2023

@mtrezza
Copy link
Member

mtrezza commented Mar 11, 2023

I'm not sure if CODECOV_TOKEN is in the in the repository secrets

We don't have a token in the secrets, IIRC that's not necessary.

It seems to work; it's actually a pretty good coverage:
image

@dplewis
Copy link
Member Author

dplewis commented Mar 11, 2023

@mtrezza This is ready for review. Here is what the coverage looks like with everything included

https://app.codecov.io/github/parse-community/Parse-SDK-iOS-OSX/commit/58c9c5be43bb403982effadee84be31d620d18c1/tree

@dplewis dplewis requested a review from mtrezza March 16, 2023 03:25
@dplewis
Copy link
Member Author

dplewis commented Mar 16, 2023

@mtrezza I made the changes. Can you review it again?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this!

@mtrezza mtrezza merged commit cbab34c into parse-community:master Mar 16, 2023
@dplewis dplewis deleted the codecov-fix branch March 19, 2023 05:24
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants