Skip to content

fix: Parse.setServer doesn't properly validate URL #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtrezza merged 1 commit into from
Jan 31, 2025
Merged

fix: Parse.setServer doesn't properly validate URL #1844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Parse.serServer doesn't handle url validation
  • Loading branch information
@dplewis
dplewis committed Jan 28, 2025
commit c65237a777f34fb56726f002d3595b928d967d04
3 changes: 0 additions & 3 deletions Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
<Test
Identifier = "ParseClientConfigurationTests/testExtensionDataSharing">
</Test>
<Test
Identifier = "ParseClientConfigurationTests/testServerValidation">
</Test>
</SkippedTests>
</TestableReference>
</Testables>
Expand Down
3 changes: 2 additions & 1 deletion Parse/Parse/Source/ParseClientConfiguration.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ - (void)setClientKey:(NSString *)clientKey {
}

- (void)setServer:(NSString *)server {
NSURL *url = [NSURL URLWithString:server];
PFParameterAssert(server.length, @"Server should not be `nil`.");
PFParameterAssert([NSURL URLWithString:server], @"Server should be a valid URL.");
PFParameterAssert(url && url.scheme && url.host, @"Server should be a valid URL.");
_server = [server copy];
}

Expand Down