Skip to content

fix: Prevent query->equalTo from overriding other conditions #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2023
Merged

fix: Prevent query->equalTo from overriding other conditions #510

merged 4 commits into from
May 13, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 12, 2023

New Pull Request Checklist

Issue Description

Closes: #476, #477

Approach

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 12, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0570f15) 98.62% compared to head (72a3246) 98.62%.

❗ Current head 72a3246 differs from pull request most recent head 61403e0. Consider uploading reports for the commit 61403e0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #510   +/-   ##
=========================================
  Coverage     98.62%   98.62%           
  Complexity     1072     1072           
=========================================
  Files            38       38           
  Lines          3264     3264           
=========================================
  Hits           3219     3219           
  Misses           45       45
Impacted Files Coverage Δ
src/Parse/ParseQuery.php 99.76% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested a review from mtrezza May 12, 2023 19:28
@dplewis dplewis changed the title fix: Prevent query.equalTo from overriding other conditions fix: Prevent query->equalTo from overriding other conditions May 12, 2023
mtrezza
mtrezza approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 0fc3d8f into parse-community:master May 13, 2023
parseplatformorg pushed a commit that referenced this pull request May 13, 2023
@semantic-release-bot
chore(release): 2.3.1 [skip ci]
8b17fa9 
## [2.3.1](2.3.0...2.3.1) (2023-05-13)

### Bug Fixes

* Prevent `query->equalTo` from overriding other conditions ([#510](#510)) ([0fc3d8f](0fc3d8f))
@parseplatformorg
Copy link

🎉 This change has been released in version 2.3.1

@parseplatformorg parseplatformorg added the state:released Released as stable version Edit label May 13, 2023
This was referenced May 13, 2023
Closed
Merged
@dplewis dplewis mentioned this pull request Jun 17, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version Edit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParseQuery::equalTo with strange behavior
3 participants
@dplewis @parseplatformorg @mtrezza