Skip to content

Use partiql_ast::ast::AstTypeMap for LocationMap #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
am357 merged 3 commits into from
Jun 14, 2023
Merged

Use partiql_ast::ast::AstTypeMap for LocationMap #394

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81926e1
Use `partiql_ast::ast::AstTypeMap` for `LocationMap`
am357 Jun 14, 2023
e77d04b
Add default-features = false
am357 Jun 14, 2023
5890532
Address PR comments
am357 Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add default-features = false
  • Loading branch information
@am357
am357 committed Jun 14, 2023
commit e77d04b97bca72a59c9492a3db017a5f7a5037b5
5 changes: 3 additions & 2 deletions partiql-ast/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ path = "src/lib.rs"
bench = false

[dependencies]
indexmap = { version = "1.9", features = ["serde"] }
indexmap = { version = "1.9", default-features = false, features = ["serde"] }
Copy link
Contributor

@jpschorr jpschorr Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to remove the unconditional features = ["serde"], since you turn it on below conditionally via serde = [... "indexmap/serde"]

Copy link
Contributor Author

@am357 am357 Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, let fix that.

rust_decimal = { version = "1.25.0", default-features = false, features = ["std"] }
serde = { version = "1.*", features = ["derive"], optional = true }

Expand All @@ -31,7 +31,8 @@ default = []
serde = [
"dep:serde",
"rust_decimal/serde-with-str",
"rust_decimal/serde"
"rust_decimal/serde",
"indexmap/serde",
]

[dependencies.partiql-ast-macros]
Expand Down