Add Catalog to NameResolver #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the work for adding a steel thread for PartiQL Typing (Recent PR #389) and after merging #410 to `feat-type-plan-poc` it is realized that we need to refactor the code to remove `DynamicLocalup` `VarExpr` with the assumption that we work based off of Typing and Value Environment from the Catalog. We have a Typing Environment in the Catalog at the moment and we are going to add the Variable Environment as well. In preparation for such task, we need to make the `NameResolver` Catalog aware. In that regard this commit adds the `Catalog` to `NameResolver` Expecting subsequent PR(s) for the name resolving using the Catalog.
am357
force-pushed
the
feat-catalog-name-resolver
branch
from
ea4d964 to
99ff05d
Compare
Conformance comparison report
Number passing in both: 5665 Number failing in both: 678 Number passing in Base (154bd59) but now fail: 0 Number failing in Base (154bd59) but now pass: 0 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 81.84% 81.87% +0.02%
==========================================
Files 62 62
Lines 15862 15883 +21
Branches 15862 15883 +21
==========================================
+ Hits 12983 13004 +21
- Misses 2361 2362 +1
+ Partials 518 517 -1
☔ View full report in Codecov by Sentry. |
jpschorr
approved these changes
Aug 16, 2023
alancai98
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
During the work for adding a steel thread for PartiQL Typing (Recent PR #389) and after merging #410 to
feat-type-plan-pocit is realized that we need to refactor the code to removeDynamicLocalupVarExprwith the assumption that we work based off of Typing and Value Environment from the Catalog. We have a Typing Environment in the Catalog at the moment and we are going to add the Variable Environment as well. In preparation for such task, we need to make theNameResolverCatalog aware. In that regard this commit adds theCatalogtoNameResolverExpecting subsequent PR(s) for the name resolving using the Catalog.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.