Skip to content

[DRAFT] Read variable name from Catalog (TypeEnv) during name resolution #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
am357 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[DRAFT] Read variable name from Catalog (TypeEnv) during name resolution #427

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7203429
Add Catalog to NameResolver
am357 Aug 16, 2023
2c33fdf
Read variable name from Catalog in NameResolver
am357 Aug 16, 2023
0d67207
[BugFix][LogicalPlanner] Read Catalog from self and default
am357 Aug 16, 2023
9df4431
Fix formatting
am357 Aug 16, 2023
531ad70
Resolve Merge Conflict
am357 Aug 16, 2023
cef2343
Experiment with the removal of error in name_resolver
am357 Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[BugFix][LogicalPlanner] Read Catalog from self and default
  • Loading branch information
@am357
am357 committed Aug 16, 2023
commit 0d67207fab166d3c388c72bd53f3ab40b7b71d66
3 changes: 1 addition & 2 deletions partiql-logical-planner/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ impl<'c> LogicalPlanner<'c> {
parsed: &Parsed,
) -> Result<logical::LogicalPlan<logical::BindingsOp>, AstTransformationError> {
let q = &parsed.ast;
let catalog = PartiqlCatalog::default();
let mut resolver = NameResolver::new(&catalog);
let mut resolver = NameResolver::new(self.catalog);
let registry = resolver.resolve(q)?;
let planner = AstToLogical::new(self.catalog, registry);
planner.lower_query(q)
Expand Down