Skip to content

Conversation

@jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 25, 2024

For the EXCLUDE clause, implements:

  • AST nodes
  • parsing,
  • pretty-printing

Cf. partiql/partiql-docs#51


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested review from alancai98 and am357 July 25, 2024 18:33
@codecov
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 61.42857% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (3ca67b7) to head (df946e4).

Files Patch % Lines
partiql-ast/src/visit.rs 0.00% 18 Missing ⚠️
partiql-ast/src/ast.rs 0.00% 6 Missing ⚠️
partiql-logical-planner/src/lower.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   81.05%   80.98%   -0.08%     
==========================================
  Files          68       68              
  Lines       18608    18680      +72     
  Branches    18608    18680      +72     
==========================================
+ Hits        15083    15128      +45     
- Misses       3082     3109      +27     
  Partials      443      443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 25, 2024

Conformance comparison report

Base (3ca67b7) c583676 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (3ca67b7) but now fail: 0

Number failing in Base (3ca67b7) but now pass: 0

@jpschorr jpschorr force-pushed the feat-parse-exclude branch from 7999c0a to 3c07a7e Compare July 25, 2024 18:50
/// A "step" within a path expression; that is the components of the expression following the root.
#[derive(Visit, Clone, Debug, PartialEq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub enum ExcludePathStep {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the naming of the enum variants are the same as PathStep

@jpschorr jpschorr merged commit 979c0cb into main Jul 25, 2024
@jpschorr jpschorr deleted the feat-parse-exclude branch July 25, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants