-
Notifications
You must be signed in to change notification settings - Fork 0
PMGR-11624: Event Inventory API Version 2 Doc Updates #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions
public-event-list.md
line 38 at r1 (raw file):
| Version| Date| Description| | --- | --- | --- | | 2.0 | 12/08/2025 | <ul><li>Adds Retail event types to payload.</li> <li>Allows for instance based sort order.</li></ul> |
Maybe say "Honors the sortOrder value on the instance (sortOrder takes precedence over formattedDate)"
public-event-list.md
line 255 at r1 (raw file):
} ], "instanceId" : "a0W8A000002uugYUAQ", "imagePath" : "https://fun-business-5001-dev-ed.scratch.my.salesforce-sites.com/ticket/servlet/servlet.ImageServer?id=015E100000DRkaO&oid=00DE100000KIuLB&lastMod=1758912375",
For the sake of consistency, can you change the domain of this URL to be the sillytickets one?
public-event-list.md
line 306 at r1 (raw file):
"seatingType" : "General Admission", "saleStatus" : "Not on sale yet", "sortOrder": 2,
whitespace difference here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @daveespo)
public-event-list.md
line 38 at r1 (raw file):
Previously, daveespo (David Esposito) wrote…
Maybe say "Honors the sortOrder value on the instance (sortOrder takes precedence over formattedDate)"
Done.
public-event-list.md
line 255 at r1 (raw file):
Previously, daveespo (David Esposito) wrote…
For the sake of consistency, can you change the domain of this URL to be the sillytickets one?
Done.
public-event-list.md
line 306 at r1 (raw file):
Previously, daveespo (David Esposito) wrote…
whitespace difference here
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daveespo reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kyledespins)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffreyazevedo reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kyledespins)
This change is