Skip to content

Conversation

kyledespins
Copy link
Contributor

@kyledespins kyledespins commented Oct 2, 2025

This change is Reviewable

Copy link
Contributor

@daveespo daveespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions


public-event-list.md line 38 at r1 (raw file):

| Version| 	Date| 	Description| 
| ---      | ---         | ---  |
| 2.0      | 12/08/2025         | <ul><li>Adds Retail event types to payload.</li> <li>Allows for instance based sort order.</li></ul>   |

Maybe say "Honors the sortOrder value on the instance (sortOrder takes precedence over formattedDate)"


public-event-list.md line 255 at r1 (raw file):

        } ],
        "instanceId" : "a0W8A000002uugYUAQ",
        "imagePath" : "https://fun-business-5001-dev-ed.scratch.my.salesforce-sites.com/ticket/servlet/servlet.ImageServer?id=015E100000DRkaO&oid=00DE100000KIuLB&lastMod=1758912375",

For the sake of consistency, can you change the domain of this URL to be the sillytickets one?


public-event-list.md line 306 at r1 (raw file):

      "seatingType" : "General Admission",
      "saleStatus" : "Not on sale yet",
			"sortOrder": 2,

whitespace difference here

Copy link
Contributor Author

@kyledespins kyledespins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @daveespo)


public-event-list.md line 38 at r1 (raw file):

Previously, daveespo (David Esposito) wrote…

Maybe say "Honors the sortOrder value on the instance (sortOrder takes precedence over formattedDate)"

Done.


public-event-list.md line 255 at r1 (raw file):

Previously, daveespo (David Esposito) wrote…

For the sake of consistency, can you change the domain of this URL to be the sillytickets one?

Done.


public-event-list.md line 306 at r1 (raw file):

Previously, daveespo (David Esposito) wrote…

whitespace difference here

Done.

Copy link
Contributor

@daveespo daveespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daveespo reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kyledespins)

Copy link
Contributor

@jeffreyazevedo jeffreyazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreyazevedo reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kyledespins)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants