Throwing error on uncompiled templates #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Twig template contains a namespace powered path like
{% include "@atoms/buttons/button.twig" %}and the file is not present, then there is no error thrown currently and the outputted Pattern simply contains this:Silent errors are the worst. This is caused by
Twig_Loader_Stringbeing the last Twig Loader in theTwig_Loader_Chainand will try to render anything thrown at it and is simply doing that above. This PR ensures that if any rendered result starts with@, then an error is thrown. I consider it a stopgap untilTwig_Loader_Chainis removed as it is currently deprecated and even contains the internal note to "NEVER use".