Skip to content

Conversation

@vladdu
Copy link
Contributor

@vladdu vladdu commented Jun 17, 2022

No description provided.

@pawamoy
Copy link
Owner

pawamoy commented Jun 18, 2022

If you're OK with it, I've started using from __future__ import annotations, which lets you write str | None instead of Optional[str], and list[str] instead of List[str].

@vladdu
Copy link
Contributor Author

vladdu commented Jun 18, 2022

Sounds good, I will update to use that. Some of these fields should not be optional, really, they are just initialized a bit late. I will see if I can do something about that.

@pawamoy
Copy link
Owner

pawamoy commented Jun 18, 2022

Yeah I never know how to handle this case (init to None and set it later). If you find a better way that's great!

@vladdu vladdu force-pushed the patch-2 branch 2 times, most recently from 76a98b6 to 07b6319 Compare June 18, 2022 14:43
@pawamoy pawamoy self-assigned this Sep 26, 2023
@pawamoy pawamoy changed the base branch from master to main August 24, 2025 15:37
@pawamoy pawamoy merged commit 9cc6e46 into pawamoy:main Aug 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants