Skip to content

Use method definition syntax for callbacks #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregjopa merged 10 commits into from
Aug 22, 2023
Merged

Use method definition syntax for callbacks #76

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
459f586
Use method definition syntax for callbacks
gregjopa Aug 22, 2023
dce7d09
debug ci
gregjopa Aug 22, 2023
91a8743
debug ci
gregjopa Aug 22, 2023
ab07b28
add debug flag
gregjopa Aug 22, 2023
17eaa7c
more debugging
gregjopa Aug 22, 2023
5e457f4
change glob pattern
gregjopa Aug 22, 2023
89aa6aa
Clean up
gregjopa Aug 22, 2023
e0f66f5
revert CI changes
gregjopa Aug 22, 2023
d31b3f4
make same changes for glob in advanced integration
gregjopa Aug 22, 2023
6800397
fix formatting
gregjopa Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert CI changes
  • Loading branch information
@gregjopa
gregjopa committed Aug 22, 2023
commit e0f66f5ddc75c60551d860c94f263ce2092fc7c3
7 changes: 3 additions & 4 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: ⎔ Setup node
uses: actions/setup-node@v3
Expand All @@ -22,10 +24,7 @@ jobs:
run: >
find . -name package.json -maxdepth 2 -type f | while read -r file; do
directory=$(dirname "$file")
cd "$directory"
echo "$PWD"
ls -l
npm run format:check && cd -
cd "$directory" && npm run format:check && cd -
done

- name: 👕 Lint code with ESLint
Expand Down