Replaced CurrencyId enum by Spacewalk Primitives CurrencyId. #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelarja
commented
Jul 11, 2023
ebma
reviewed
Jul 12, 2023
Member
ebma
left a comment
ebma
left a comment
There was a problem hiding this comment.
I just left some nit-picky comments on how I would prefer the import structure to be.
I know that the PendulumCurrencyId is something that existed before and you just adapted the code to that @adelarja, but while reading through the changes I realized that having that extra type might not be ideal. Again, it's quite minor. Rest LGTM
adelarja
changed the title
TorstenStueber
approved these changes
Jul 14, 2023
Contributor
TorstenStueber
left a comment
TorstenStueber
left a comment
There was a problem hiding this comment.
No objections. Looks good.
ebma
deleted the
271-updatereplace-pendulums-currencyid-with-the-one-defined-in-spacewalk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the
CurrencyIdenum from pendulum's runtime, with theCurrencyIdenum from the spacewalk primitives.We need to do this in order to implement the ZenlinkProtocol Runtime API for pendulum chain in this PR.
zenlink_id_to_currency_id function will be used for the ZenlinkProtocol Runtime API to convert between zenlink assets to spacewalk currencies. The current implementation will be replaced by the same implementation of the zenlink runtime common module which was used for Amplitude and Foucoco in the previous PR.