Skip to content

Conversation

@cratelyn
Copy link
Contributor

fixes #3119. see also, #1886.

this pulls the auto-https code (see #3627, #3652) into a standalone library crate.

fixes #3119. see also, #1886.

this pulls the auto-https code (see #3627, #3652) into a standalone
library crate.
@cratelyn cratelyn added A-node Area: System design and implementation for node software E-easy Effort: Easy labels Jan 31, 2024
@cratelyn cratelyn self-assigned this Jan 31, 2024
@cratelyn cratelyn marked this pull request as ready for review January 31, 2024 19:11
@cratelyn cratelyn requested a review from conorsch January 31, 2024 19:43
Copy link
Member

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't functionally verified that there's no breakage, but the diff is clean and readable. Post-merge I'll rebase the WIP #3709 and resume testing.

@conorsch conorsch merged commit feb5958 into main Jan 31, 2024
@conorsch conorsch deleted the katie/extract-auto-https branch January 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-node Area: System design and implementation for node software E-easy Effort: Easy

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Extract pd auto-https code into standalone utility crate, or else make it unnecessary

3 participants