Skip to content

tests(app): 🌯 reorganize, rename mock consensus integration tests #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cratelyn merged 4 commits into from
Mar 26, 2024
Merged

tests(app): 🌯 reorganize, rename mock consensus integration tests #4103

cratelyn merged 4 commits into from
Mar 26, 2024

Conversation

@cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Mar 26, 2024

it's probably about time to rename the app/tests/mock_consensus\w*.rs tests, and the test cases contained therein. at this point they're becoming the app test suite, so phrasing them as though they're exercising the mock engine is a little backwards

this follows up on this note, from the discord's #testing channel.

cratelyn added 4 commits March 26, 2024 09:39
@cratelyn
tests(app): 🔙 reënable keyring insertion in test
092e90f 
this code was commented out when working on #4044. as of #4070,
(see #4040) we now sign blocks. let's turn this code back on.
@cratelyn
tests(app): 🔖 rename staking integration test
c01ca43
@cratelyn
tests(app): 🐣 move mock_consensus.rs to init_chain.rs
c554f0d
@cratelyn
tests(app): 💸 outline app_can_spend_notes_and_detect_outputs
7656f26 
(NB: renamed from `mock_consensus_can_spend_notes_and_detect_outputs`)
@cratelyn cratelyn added C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. A-testing Area: Relates to testing of Penumbra A-mock-consensus Area: Relates to the mock consensus engine labels Mar 26, 2024
@cratelyn cratelyn self-assigned this Mar 26, 2024
@cratelyn cratelyn added this to the Sprint 3 milestone Mar 26, 2024
@cratelyn cratelyn marked this pull request as ready for review March 26, 2024 15:42
@cratelyn cratelyn merged commit 85823bd into main Mar 26, 2024
@cratelyn cratelyn deleted the kate/mock-consensus-staking-claim-undelegation-tokens branch March 26, 2024 15:42
@cratelyn cratelyn mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cratelyn cratelyn

Labels

A-mock-consensus Area: Relates to the mock consensus engine A-testing Area: Relates to testing of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.

Projects

Penumbra
Archived in project

Milestone

Sprint 3

Development

Successfully merging this pull request may close these issues.

2 participants

@cratelyn