Add node status page #592
Add node status page #592
Conversation
grod220
force-pushed
the
node-status-app
branch
from
6c8f163 to
e2e9d3a
Compare
|
This looks amazing! |
jessepinho
left a comment
jessepinho
left a comment
There was a problem hiding this comment.
Not sure what some of the fields mean (e.g., should channels really be base64ed? not sure how to review that) but otherwise LGTM!
|
|
||
| export const FrontendReferral = () => { | ||
| const onClickHandler = () => { | ||
| window.open(import.meta.env.MODE === 'production' ? prodFrontend : devFrontend); |
There was a problem hiding this comment.
why not use process.env.NODE_ENV? Not available in Vite?
There was a problem hiding this comment.
Because this code will be executed in a browser environment, getting env variables that way will throw. Vite provides this as a kind analogous way to access env variables with a client side app.
| const VISIBILITY_STATE_CHANGE_DELAY = 800; | ||
|
|
||
| // Meant to slow down the state transition from loading to idle so the UI can show a discernible spinner | ||
| export const useDeceleratedFetchState = () => { |
There was a problem hiding this comment.
This hook name threw me off a bit. What about something like useDelayedIsLoading? Hm... maybe it's not better. It just took me a minute to realize what this hook was actually doing.
|
|
||
| export const FrontendReferral = () => { | ||
| const onClickHandler = () => { | ||
| window.open(import.meta.env.MODE === 'production' ? prodFrontend : devFrontend); |
There was a problem hiding this comment.
Because this code will be executed in a browser environment, getting env variables that way will throw. Vite provides this as a kind analogous way to access env variables with a client side app.
| const VISIBILITY_STATE_CHANGE_DELAY = 800; | ||
|
|
||
| // Meant to slow down the state transition from loading to idle so the UI can show a discernible spinner | ||
| export const useDeceleratedFetchState = () => { |
| </div> | ||
| <div className='flex flex-col'> | ||
| <strong>Channels</strong> | ||
| <span className='ml-2'>{uint8ArrayToBase64(nodeInfo.channels)}</span> |
There was a problem hiding this comment.
Swapping to uint8ArrayToString
grod220
force-pushed
the
node-status-app
branch
from
e2e9d3a to
38b627f
Compare
* Add node status page * review updates
Closes #513
Screen.Recording.2024-02-22.at.1.31.02.PM.mov