PMM-13959 remove GSSAPI from main builds #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
BupycHuk
reviewed
May 12, 2025
|
|
||
| build: ## Compile using plain go build | ||
| CGO_ENABLED=1 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter -tags gssapi | ||
| go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter |
There was a problem hiding this comment.
this revert PR could include only this as everything else doesn't affect PMM really
There was a problem hiding this comment.
We want to still keep GSSAPI support in goreleaser builds? @BupycHuk
There was a problem hiding this comment.
I imagine we can drop it too, and in that case drop the tests as well (which removes the need for the other files).
We still have the original PR, so if we need to prepare some builds, we can base them on that.
There was a problem hiding this comment.
We can have additional build of mongodb_exporter with gssapi
idoqo
force-pushed
the
PMM-13748-drop-gssapi-support
branch
from
587cb34 to
b52e0a4
Compare
ademidoff
approved these changes
May 13, 2025
ademidoff
reviewed
May 13, 2025
| goos: | ||
| - linux | ||
| - darwin | ||
| - windows |
There was a problem hiding this comment.
I wouldn't care about windows :)
It's not the Operating System we support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13748
PMM-13959