PS-9704 [8.0]: Escape all RFC 4515 special chars in LDAP filter substitutions#5928
Open
VarunNagaraju wants to merge 1 commit into
Open
PS-9704 [8.0]: Escape all RFC 4515 special chars in LDAP filter substitutions#5928VarunNagaraju wants to merge 1 commit into
VarunNagaraju wants to merge 1 commit into
Conversation
VarunNagaraju
changed the title
VarunNagaraju
changed the title
…itutions https://perconadev.atlassian.net/browse/PS-9704 User-supplied values (user_name, user_dn) substituted into LDAP search filters via {UA} and {UD} were not properly escaped. Only double-quote received a partial treatment; parentheses, asterisk, backslash, and NUL were passed through verbatim, producing malformed filters that silently broke group lookups. Add ldap_filter_escape() which applies the mandatory RFC 4515 \XX hex encoding for NUL (\00), ( (\28), ) (\29), * (\2a), and \ (\5c). Apply it to all three substitution sites: search_dn() for user_name, and search_groups() for both {UA} (user_name) and {UD} (user_dn). MTR test exercises DN containing a double-quote, parentheses, an asterisk, and a backslash — all expected to receive their group role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-9704
User-supplied values (user_name, user_dn) substituted into LDAP search
filters via {UA} and {UD} were not properly escaped. Only double-quote
received a partial treatment; parentheses, asterisk, backslash, and NUL
were passed through verbatim, producing malformed filters that silently
broke group lookups.
Add ldap_filter_escape() which applies the mandatory RFC 4515 \XX
hex encoding for NUL (\00), ( (\28), ) (\29), * (\2a), and \ (\5c).
Apply it to all three substitution sites: search_dn() for user_name,
and search_groups() for both {UA} (user_name) and {UD} (user_dn).
MTR test exercises DN containing a double-quote, parentheses, an
asterisk, and a backslash — all expected to receive their group role.