Skip to content

[FIX] ImageSimilarity / OpenCV Error: Assertion failed... #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[FIX] ImageSimilarity / OpenCV Error: Assertion failed... #381

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dc02f9b
fix assertion failed error
Feb 29, 2016
5263a43
fix assertion failed error
Feb 29, 2016
413dd7b
fix assertion failed error
Feb 29, 2016
12c1c4f
fix assertion failed error
Feb 29, 2016
938f048
fix assertion failed error
Feb 29, 2016
c26e955
fix assertion failed error
Feb 29, 2016
5f63d23
fix assertion failed error
Feb 29, 2016
70ed636
Merge pull request #1 from peterbraden/master
tanasebutcaru Apr 9, 2016
2273e55
Merge pull request #2 from peterbraden/master
tanasebutcaru Apr 21, 2016
87d1a02
Merge pull request #3 from peterbraden/master
tanasebutcaru Apr 23, 2016
7f2f3ee
Merge pull request #4 from peterbraden/master
tanasebutcaru May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix assertion failed error
  • Loading branch information
TanaseButcaru committed Feb 29, 2016
commit 5f63d23899b20f910b86eea1d79c8d1c03a7f4ec
16 changes: 6 additions & 10 deletions src/Features2d.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class AsyncDetectSimilarity: public Nan::AsyncWorker {
extractor->compute(image1, keypoints1, descriptors1);
extractor->compute(image2, keypoints2, descriptors2);


//fix for 'Assertion failed...' error
//source: http://stackoverflow.com/questions/15650371/matcher-assertions-failed-error-opencv-android
if (descriptors1.type() == descriptors2.type() && descriptors1.cols == descriptors2.cols) {
matcher->match(descriptors1, descriptors2, matches);

Expand Down Expand Up @@ -84,14 +85,7 @@ class AsyncDetectSimilarity: public Nan::AsyncWorker {

}
else {
Nan::HandleScope scope;

Local<Value> argv[2];

argv[0] = Nan::Null();
argv[1] = Nan::Null();

callback->Call(2, argv);
dissimilarity = std::numeric_limits<double>::quiet_NaN();
}

}
Expand All @@ -102,7 +96,9 @@ class AsyncDetectSimilarity: public Nan::AsyncWorker {
Local<Value> argv[2];

argv[0] = Nan::Null();
argv[1] = Nan::New<Number>(dissimilarity);

if (dissimilarity != dissimilarity) argv[1] = Nan::Null();
else argv[1] = Nan::New<Number>(dissimilarity);

callback->Call(2, argv);
}
Expand Down