Skip to content

Commit ce53833

Browse files
committed
[SPARK-16436][SQL] checkEvaluation should support NaN
## What changes were proposed in this pull request? This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons. ## How was this patch tested? This is a test harness change. Author: petermaxlee <petermaxlee@gmail.com> Closes apache#14103 from petermaxlee/SPARK-16436.
1 parent 4d6f654 commit ce53833

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
6363
expected.asInstanceOf[Spread[Double]].isWithin(result)
6464
case (result: MapData, expected: MapData) =>
6565
result.keyArray() == expected.keyArray() && result.valueArray() == expected.valueArray()
66+
case (result: Double, expected: Double) =>
67+
if (expected.isNaN) result.isNaN else expected == result
68+
case (result: Float, expected: Float) =>
69+
if (expected.isNaN) result.isNaN else expected == result
6670
case _ =>
6771
result == expected
6872
}

0 commit comments

Comments
 (0)