[SPARK-16436][SQL] checkEvaluation should support NaN #14103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan |
| expected.asInstanceOf[Spread[Double]].isWithin(result) | ||
| case (result: MapData, expected: MapData) => | ||
| result.keyArray() == expected.keyArray() && result.valueArray() == expected.valueArray() | ||
| case (result: Double, expected: Double) => |
Contributor
There was a problem hiding this comment.
shoud we also handle isInfinite
Contributor
Author
There was a problem hiding this comment.
scala> Double.PositiveInfinity == Double.PositiveInfinity
res2: Boolean = true
it already works
|
Test build #61955 has finished for PR 14103 at commit
|
petermaxlee
changed the title
|
Test build #61966 has finished for PR 14103 at commit
|
Contributor
|
thanks, merging to master! |
petermaxlee
added a commit
to petermaxlee/spark
that referenced
this pull request
Jul 11, 2016
## What changes were proposed in this pull request? This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons. ## How was this patch tested? This is a test harness change. Author: petermaxlee <[email protected]> Closes apache#14103 from petermaxlee/SPARK-16436.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This small patch modifies ExpressionEvalHelper. checkEvaluation to support comparing NaN values for floating point comparisons.
How was this patch tested?
This is a test harness change.