Skip to content

Add <hr/> support to options_for_select #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteffenDE merged 3 commits into from
Oct 21, 2024
Merged

Add <hr/> support to options_for_select #451

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d30c20b
Add <hr/> to options_for_select
gilbertbw Oct 18, 2024
2cea68e
Fix formatting
gilbertbw Oct 18, 2024
465c303
Update lib/phoenix_html/form.ex
SteffenDE Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@gilbertbw
gilbertbw committed Oct 18, 2024
commit 2cea68e9820099ad89e88fa2d7ee3f6a7fdebcbd
14 changes: 7 additions & 7 deletions test/phoenix_html/form_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,9 @@ defmodule Phoenix.HTML.FormTest do
~s(<option selected value="novalue">novalue</option>)

assert options_for_select(["value", :hr, "novalue"], "novalue") |> safe_to_string() ==
~s(<option value="value">value</option>) <>
~s(<hr/>) <>
~s(<option selected value="novalue">novalue</option>)
~s(<option value="value">value</option>) <>
~s(<hr/>) <>
~s(<option selected value="novalue">novalue</option>)

assert options_for_select(
[
Expand All @@ -274,10 +274,10 @@ defmodule Phoenix.HTML.FormTest do
~s(<option selected value="value">value</option>) <>
~s(<option selected value="novalue">novalue</option>)

assert options_for_select(["Label": "value", hr: nil, "New": "new"], nil) |> safe_to_string() ==
~s(<option value="value">Label</option>) <>
~s(<hr/>) <>
~s(<option value="new">New</option>)
assert options_for_select([Label: "value", hr: nil, New: "new"], nil) |> safe_to_string() ==
~s(<option value="value">Label</option>) <>
~s(<hr/>) <>
~s(<option value="new">New</option>)
end

test "with groups" do
Expand Down