Skip to content

Conversation

@php-coder
Copy link
Owner

@php-coder php-coder commented Nov 30, 2017

Second attempt. The first was in #713
Addressed to #755

@mystamps-bot
Copy link

mystamps-bot commented Nov 30, 2017

2 Warnings
⚠️ danger check: pull request contains 8 commits while most of the cases it should have only one. If it’s not a special case you should squash the commits into single one.
But be careful because it can destroy all your changes!
⚠️ danger check: branch use_codecov does not comply with our best practices. Branch name should use the following scheme: ghXXX_meaningful-name where XXX is an issue number. Next time, please, use this scheme :)

Generated by 🚫 Danger

@php-coder php-coder force-pushed the use_codecov branch 2 times, most recently from 58046c0 to 428f971 Compare December 4, 2017 11:52
@codecov
Copy link

codecov bot commented Dec 8, 2017

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #714   +/-   ##
=========================================
  Coverage     70.63%   70.63%           
  Complexity      390      390           
=========================================
  Files            28       28           
  Lines          1209     1209           
  Branches        168      168           
=========================================
  Hits            854      854           
  Misses          343      343           
  Partials         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8fed95...683ec90. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants