Skip to content

[Redis] Add ability to pass Redis instance to connection factory #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2018
Merged

[Redis] Add ability to pass Redis instance to connection factory #372

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3791b63
[redis] Add ability to pass instance of Redis instance.
makasim Feb 15, 2018
f4b97d5
[redis][symfony] Add ability to set custom redis instance in transpor…
makasim Feb 15, 2018
5c9af8d
[simple-client] Add ability to pass container builder.
makasim Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[simple-client] Add ability to pass container builder.
  • Loading branch information
@makasim
makasim committed Feb 15, 2018
commit 5c9af8de83c071fa2fa5f62dd32bcf5d772d41c7
24 changes: 16 additions & 8 deletions pkg/simple-client/SimpleClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,20 @@
use Interop\Queue\PsrContext;
use Interop\Queue\PsrProcessor;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;

final class SimpleClient
{
/**
* @var ContainerBuilder
* @var ContainerInterface
*/
private $container;

/**
* @var array|string
*/
private $config;

/**
* The config could be a transport DSN (string) or an array, here's an example of a few DSNs:.
*
Expand Down Expand Up @@ -73,11 +79,13 @@ final class SimpleClient
* ]
*
*
* @param string|array $config
* @param string|array $config
* @param ContainerBuilder|null $container
*/
public function __construct($config)
public function __construct($config, ContainerBuilder $container = null)
{
$this->container = $this->buildContainer($config);
$this->container = $this->buildContainer($config, $container ?: new ContainerBuilder());
$this->config = $config;
}

/**
Expand Down Expand Up @@ -252,16 +260,16 @@ public function getRouterProcessor()
}

/**
* @param array|string $config
* @param array|string $config
* @param ContainerBuilder $container
*
* @return ContainerBuilder
* @return ContainerInterface
*/
private function buildContainer($config)
private function buildContainer($config, ContainerBuilder $container)
{
$config = $this->buildConfig($config);
$extension = $this->buildContainerExtension();

$container = new ContainerBuilder();
$container->registerExtension($extension);
$container->loadFromExtension($extension->getAlias(), $config);

Expand Down