Fix: Remove WP_Error from get_term_by return type #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_term_by` calls `get_terms` and `get_term`, both of which can return a `WP_Error` object if the taxonomy specified in `$args['taxonomy']` (corresponding to the `$taxonomy` parameter of `get_term_by`) does not exist. However, `get_term_by` handles any potential errors from `get_term` and `get_terms` by converting them into a `false` return value, thereby ensuring it never directly returns a `WP_Error` object. Removing `WP_Error` from the return type of `get_term_by` reflects the actual behaviour of the function. Closes php-stubs#284
|
Much better now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_term_bycallsget_termsandget_term, both of which can return aWP_Errorobject if the taxonomy specified in$args['taxonomy'](corresponding to the$taxonomyparameter ofget_term_by) does not exist. However,get_term_byhandles any potential errors fromget_termandget_termsby converting them into afalsereturn value, thereby ensuring it never directly returns aWP_Errorobject.Removing
WP_Errorfrom the return type ofget_term_byreflects the actual behaviour of the function.Closes #284