Skip to content

Virtual cwd refactoring #15524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Girgias wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Virtual cwd refactoring #15524

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
439f904
Zend: Refactor VCWD_CHDIR_FILE() to take path length
Girgias Aug 21, 2024
1c33031
Remove duplicate test conditions
Girgias Aug 21, 2024
84e39bb
Zend: Refactor virtual_file_ex() to take path length
Girgias Aug 21, 2024
64a2693
Zend: Refactor virtual_rename() to take path lengths
Girgias Aug 21, 2024
60782d2
ext/standard: Use zend_string for path of move_uploaded_file()
Girgias Aug 21, 2024
2eb31b5
Use CLEAN section in some tests
Girgias Aug 21, 2024
8d5e3a9
streams: Refactor rename stream op to use zend_string
Girgias Aug 21, 2024
9048e85
Zend: Refactor virtual_rmdir() to take path lengths
Girgias Aug 21, 2024
d8f33a2
Add a CLEAN section
Girgias Aug 22, 2024
567d8b5
streams: Refactor rmdir stream op to use zend_string
Girgias Aug 22, 2024
947c402
Zend: Refactor virtual_unlink() to take path lengths
Girgias Aug 23, 2024
5194bd9
streams: Refactor unlink stream op to use zend_string
Girgias Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a CLEAN section
  • Loading branch information
@Girgias
Girgias committed Aug 23, 2024
commit d8f33a2f380059c04b0a9eecc28d840f609d1f44
7 changes: 6 additions & 1 deletion ext/standard/tests/file/bug68335.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,17 @@
Bug #68335: rmdir doesn't work with file:// stream wrapper
--FILE--
<?php
$dir = 'file://' . __DIR__ . '/testDir';
$dir = 'file://' . __DIR__ . '/test_68335_dir';
mkdir($dir);
var_dump(is_dir($dir));
rmdir($dir);
var_dump(is_dir($dir));
?>
--CLEAN--
<?php
$dir = __DIR__ . '/test_68335_dir';
@rmdir($dir);
?>
--EXPECT--
bool(true)
bool(false)