Skip to content

Fix GH-16319: protect fiber backtrace with null filename from crashing #19973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: PHP-8.3
Choose a base branch
from
Open

Fix GH-16319: protect fiber backtrace with null filename from crashing #19973

wants to merge 2 commits into from
+50 −2

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Sep 26, 2025 •
edited
Loading

Fix #16319

Used [no active file] as it's already used at many places.

@alexandre-daubois alexandre-daubois changed the base branch from master to PHP-8.3 September 26, 2025 14:43
@alexandre-daubois alexandre-daubois linked an issue Sep 26, 2025 that may be closed by this pull request
Segmentation fault in ext/zend_test/observer.c:175 #16319
Open
@alexandre-daubois alexandre-daubois marked this pull request as ready for review September 26, 2025 15:05
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Sep 26, 2025 •
edited
Loading

Not sure how to skip the test on CircleCI, where it seems that --enable-zend-test isn't provided? Help welcome 🙂

iluuu1994
iluuu1994 approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

NEWS Outdated
. Fixed bug GH-19480 (error_log php.ini cannot be unset when open_basedir is
configured). (nielsdos)
. Fixed bug GH-16319 (Prevent crash when displaying fiber backtrace with
a null filename). (alexandre-daubois)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this NEWS entry, zend_test is not a user-targeted extension.

@iluuu1994
Copy link
Member

Not sure how to skip the test on CircleCI, where it seems that --enable-zend-test isn't provided? Help welcome 🙂

I don't think it's because the extension is not available, that is skipped with --EXTENSIONS--. It might be because of --repeat 2, or JIT.

@alexandre-daubois
Copy link
Member Author

Skipping when using JIT in CircleCI seems to do the trick

@iluuu1994
Copy link
Member

I'm not sure if this is expected though? Other observer tests are not skipped with JIT.

@iluuu1994
Copy link
Member

Okay, I can see some where JIT is explicitly disabled like you do, e.g. (ext/zend_test/tests/observer_opline_01.phpt). So this looks ok to me now. 👍

@alexandre-daubois
Copy link
Member Author

Oh indeed! I was about to ping Arnaud. Thanks for pointing an existing case!

@alexandre-daubois alexandre-daubois force-pushed the obs-fiber-bt branch 3 times, most recently from a64c738 to e857638 Compare September 29, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault in ext/zend_test/observer.c:175
2 participants
@alexandre-daubois @iluuu1994