Fix #18 Preventing custom roles to duplicate files from default roles.

src/Onion/Pear/PackageXmlGenerator.php

@@ -144,6 +144,9 @@ function generate()
 			$customRoles = $config->get('roles');
             if( $customRoles ) {
                 foreach( $customRoles as $pattern => $role ) {
+                    if (in_array($pattern, $roles['test'])) {
+                        continue;
+                    }
                     $logger->debug( "treat \"$pattern\" as \"$role\" role" , 1 );
                     $files = $this->addPathByRole( $pattern , $role );
                     $filelist = array_merge( $filelist, $files);
@@ -264,15 +267,15 @@ function addPathByRole( $path , $role )
 			foreach( $iterator as $path ) {
 				if( $path->isFile() ) {
                     $filepath = $path->getPathname();
-                    $list[] = $this->buildContentFile( $path, $role, $baseDir );
+                    $list[(string) $path] = $this->buildContentFile( $path, $role, $baseDir );
 				}
 			}
 		}
 		else {
 			$files = glob($path);
 			foreach( $files as $filename ) {
 				$fileinfo = new SplFileInfo($filename);
-                $list[] = $this->buildContentFile( $fileinfo , $role );
+                $list[(string) $filename] = $this->buildContentFile( $fileinfo , $role );
 			}
 		}
         return $list;

tests/Onion/Pear/PackageXmlGeneratorTest.php

@@ -35,4 +35,24 @@ function test()
 
         // do validations from xsd file.
 	}
+
+    function test2()
+    {
+        $logger = \Onion\Application::getLogger();
+        $logger->setLevel( 0 );
+
+        $config = new \Onion\PackageConfigReader();
+        $config->setLogger( $logger );
+
+        $package = $config->read( 'package.ini' );
+        $package->config->array['roles']['src'] = 'php';
+
+        $generator = new \Onion\Pear\PackageXmlGenerator( $package );
+        $generator->setLogger( $logger );
+
+        $installElement = '<install name="src/Onion/Application.php" as="Onion/Application.php"/>';
+        $generatedXml = $generator->generate();
+
+        is(1, substr_count($generatedXml, $installElement), 'Only one install should appear per file.');
+    }
 }