Develop #21
Closed
Develop #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感謝你的 patch :-) 我建議 script role 吃 bin/ 目錄就好, 不然像現在底下 scripts/ 的很多就會被裝到同一個空間，會造成混亂 |
|
其實用法上還是有很多比較困惑的地方，因為後來發現有 roles 這個設定，但是看不太出來它會被怎麼利用。 這個 Patch 如果跟現在功能衝突的話，可以忽略。 慢慢會從 Source Code 再看看有沒有我沒仔細看到的功能的。 |
|
發現還是用你原來的寫法比較好，不過這邊我會用文章來寫一下說明。 |
|
OK! |
|
我後來發現你原來的作法要把 shell script 放在最外面才行，如果放在自訂的 bin 資料夾底下的話，它在安裝時會安裝到 bin/bin 底下。 |
|
所以應該是要把 dirname 去掉，只留下 basename :-) |
|
已經重新提交新的程式碼了。 |
|
感謝 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原來的 script/scripts 有用到，所以我改成只用 bin 資料夾就好。