Skip to content

Conversation

@jaceju
Copy link
Contributor

@jaceju jaceju commented Jun 28, 2012

修正一

當系統已經透過 pear 安裝 Onion 時,會使得開發用的 scripts/onion 指令受到干擾。

修正為 scripts/onion 指令只讀取開發用的 Onion 及 vendor 套件。

修正二

當 package.ini 設定為:

[roles]
bin/my_script = script

會使得 my_script 安裝到 bin/bin 資料夾下。

修正為安裝到正確的 bin 資料夾下。

@c9s
Copy link
Member

c9s commented Jun 28, 2012

OK, Thanks :-)

不過空白的修改太多了,看不太出來是哪邊的 Logic 有修改 orz

可能要麻煩你 Code 改的時候再做 indentation,這樣 diff 比較知道改了什麼

另外就是 tab 的設定,一般專案都是使用 expandtab 和 tab width = 4

@c9s
Copy link
Member

c9s commented Jun 28, 2012

應該說 indentation 分出來另外 commit 會比較好一點 ^^

c9s added a commit that referenced this pull request Jun 28, 2012
修正 role:scripts 安裝的方式
@c9s c9s merged commit c7c3cc2 into phpbrew:develop Jun 28, 2012
@c9s
Copy link
Member

c9s commented Jun 28, 2012

應該是我這邊 vim 怪怪的,有時候 expandtab option 會跳回去, 所以部分 indentation 才會不同

@jaceju
Copy link
Contributor Author

jaceju commented Jun 28, 2012

我剛剛不小心有按到 reformat ,有改回來,但好像還是送出去了,真抱歉。 @@

@jaceju
Copy link
Contributor Author

jaceju commented Jun 28, 2012

我都是用 4 spaces 。

@c9s
Copy link
Member

c9s commented Jun 28, 2012

沒關係! :-)

@c9s
Copy link
Member

c9s commented Jun 28, 2012

對了 如果修改有問題的話,可以到 #php-tw ,我在上面 :-)

On Thu, Jun 28, 2012 at 3:07 PM, Jace Ju <
[email protected]

wrote:

我都是用 4 spaces 。


Reply to this email directly or view it on GitHub:
#25 (comment)

Best Regards,

Yo-An Lin

@jaceju
Copy link
Contributor Author

jaceju commented Jun 28, 2012

OK !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants