Issue31 fixing tests #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------------------------------------------------------------- Added structure key support to PEAR package generator. It accepts a comma separated list as value or a simple value. This change make package generation more flexible and not dependent on a fixed structure.
Some tests were failing because of the use of logger property in a static way. The changes done here are all about use the method getLogger() to get the logger property in a proper way.
There was a problem hiding this comment.
You can write your idea in doc/plans (and expand it as a plan later) ;-)
There was a problem hiding this comment.
This is a folder of project configuration created by PhpStorm so the next developer do not need to have it :-)
There was a problem hiding this comment.
Cool~ thanks ;-)
2012/9/17 Nelson Senna do Amaral [email protected]
In .gitignore:
@@ -1,3 +1,4 @@
.onion
vendor
tests/tmp
+.idea/This is a folder of project configuration created by PhpStorm so the next
developer do not need to have it :-)—
Reply to this email directly or view it on GitHubhttps://github.com//pull/35/files#r1614843.
Best Regards,
Yo-An Lin
|
Everything looks good! awesome! Thanks for this patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just reopened that... I think I removed the branch! Sorry about that!