-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Pi-hole Core v5.3 #4113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pi-hole Core v5.3 #4113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ...) and number of (in-)valid domains on this list in the gravity database. This updates the gravity databaes to version 14. Signed-off-by: DL6ER <[email protected]>
… the list content changed since the last download Signed-off-by: DL6ER <[email protected]>
… time or when it really changed content Signed-off-by: DL6ER <[email protected]>
…d not the sum of the so far collected number of domains) Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
The CLI and the UI should do the same to be able to add/remove the same records via any supported interface. Signed-off-by: Andras Tim <[email protected]>
fixed typos
sysconfig network scripts are missing on pure NetworkManager installs. This commit touches a placeholder to allow the network configuration to be generated and loaded via NetworkManager. Signed-off-by: bcambl <[email protected]>
Signed-off-by: bcambl <[email protected]>
Signed-off-by: mtzfederico <[email protected]>
Signed-off-by: Michael Woolweaver <[email protected]>
fix suspected typo in comment
Signed-off-by: Alexander Schmitz <[email protected]>
Fix issue with multipe default gateways when running the debug
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Add hostname to teleporter backup file if called from cli
Updates lighttpd config to allow a persistent port change on IPv6
Store gravity details in gravity.db adlist table
Signed-off-by: DL6ER <[email protected]>
Fix `pihole -g -r`
* Aligned pihole logo to center, Fixed responsive issue * removed duplicate instance of #splashpage Signed-off-by: Dany Gauthier <[email protected]>
Fix list: User same wildcard regex that the UI use
Signed-off-by: jbzdarkid <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…ough `sed` Signed-off-by: Adam Warner <[email protected]>
Improve comments in basic-install.sh
Signed-off-by: jbzdarkid <[email protected]>
Also updated a comment to point to a non-experimental RFC. Signed-off-by: jbzdarkid <[email protected]>
Signed-off-by: Jaime Baez <[email protected]>
pihole -g should respose GRAVITYDB in pihole-FTL.conf
Fix error trying to access undefined variables on splash page.
Improve regexes for IPv4 matching
Signed-off-by: bcambl <[email protected]>
Fedora 33 Support
DL6ER
previously approved these changes
Apr 13, 2021
Member
DL6ER
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test for Fedora 33 is expected to fail as DNS record needs to get updated.
* Try to obtain FTL's PID from the PID file. If this fails, try to identify the main process using pgrep --oldest (instead of relying on pkill finding the right one by itself). This allows the script to work in even when FTL is running inside the memory checker valgrind. * Rename FTL_PID -> FTL_PID_FILE * Remove the pgrep fallback after discussions about that it should be more obvious to users if something strange happened to their PID file. Also, simplify the routine using a bashism in the end. * Shorten if [[ regex ]] * Use unset instead of emptying the PID variable Signed-off-by: DL6ER <[email protected]> Co-authored-by: Dan Schaper <[email protected]>
DL6ER
previously approved these changes
Apr 14, 2021
Update README
dschaper
previously approved these changes
Apr 14, 2021
Add some validation to passed arguments before running the values through `sed`
dschaper
approved these changes
Apr 14, 2021
DL6ER
reviewed
Apr 14, 2021
Member
DL6ER
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Post-merge approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release PR