Skip to content

Conversation

@rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Oct 14, 2022

What does this PR aim to accomplish?

Add info about versions file to the debug log.

Context:
Recently we introduced versions file to /etc/pihole directory.
We use this file in a lot of places, but a check for this file was never included in the debug log.

Including this check will show extra info: file last update time, file permissions and file content:

-rw-r--r-- 1 root pihole 291 Oct 13 20:24 /etc/pihole/versions
   CORE_BRANCH=development
   WEB_BRANCH=topboxlink
   FTL_BRANCH=development
   CORE_VERSION=v5.12.2-43-g997a771
   WEB_VERSION=v5.15.1-32-g16823707
   FTL_VERSION=vDev-2de12e2
   DOCKER_VERSION=nightly
   GITHUB_CORE_VERSION=v5.13
   GITHUB_WEB_VERSION=v5.16
   GITHUB_FTL_VERSION=v5.18.2
   GITHUB_DOCKER_VERSION=2022.10

How does this PR accomplish the above?

Adding versions file to the REQUIRED_FILES list.

What documentation changes (if any) are needed to support this PR?

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team October 14, 2022 17:22
@rdwebdesign rdwebdesign changed the title Add versions file to the REQUIRED_FILES list Check versions file on the debug log Oct 14, 2022
@dschaper dschaper merged commit 3491dbf into development Oct 31, 2022
@dschaper dschaper deleted the debuglog_versionsfile branch October 31, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants